Skip to content

Commit

Permalink
refactor(wip): minor update
Browse files Browse the repository at this point in the history
  • Loading branch information
tiwaojo committed Sep 28, 2023
1 parent d9d546a commit 69d6389
Show file tree
Hide file tree
Showing 6 changed files with 293 additions and 296 deletions.
50 changes: 24 additions & 26 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
@@ -1,29 +1,27 @@
// For format details, see https://aka.ms/devcontainer.json. For config options, see the
// README at: https://github.com/devcontainers/templates/tree/main/src/typescript-node
{
"name": "foxglove-mcap-dev",
// Or use a Dockerfile or Docker Compose file. More info: https://containers.dev/guide/dockerfile
"image": "mcr.microsoft.com/devcontainers/typescript-node:latest",
"features": {
"ghcr.io/devcontainers-contrib/features/pnpm": {
"version": "latest"
},
"ghcr.io/devcontainers/features/git": {}
},
// Features to add to the dev container. More info: https://containers.dev/features.
// "features": {},
// Use 'forwardPorts' to make a list of ports inside the container available locally.
// "forwardPorts": [],
// Use 'postCreateCommand' to run commands after the container is created.
"postCreateCommand": "pnpm i && npm i -g @vscode/vsce",
// Configure tool-specific properties.
"customizations": {
"vscode": {
"extensions": [
"esbenp.prettier-vscode"
]
}
},
// Uncomment to connect as root instead. More info: https://aka.ms/dev-containers-non-root.
// "remoteUser": "root"
}
"name": "foxglove-mcap-dev",
// Or use a Dockerfile or Docker Compose file. More info: https://containers.dev/guide/dockerfile
"image": "mcr.microsoft.com/devcontainers/typescript-node:latest",
// Features to add to the dev container. More info: https://containers.dev/features.
"features": {
"ghcr.io/devcontainers-contrib/features/pnpm": {
"version": "latest"
},
"ghcr.io/devcontainers/features/git": {},
"ghcr.io/tiwaojo/features/mcap-cli": {}
},
"workspaceFolder": "/home/node/${localWorkspaceFolderBasename}",
"workspaceMount": "source=${localWorkspaceFolder},target=/home/node/${localWorkspaceFolderBasename},type=bind",
// Use 'postCreateCommand' to run commands after the container is created.
"postCreateCommand": "pnpm i && npm i -g @vscode/vsce",
// Configure tool-specific properties.
"customizations": {
"vscode": {
"extensions": ["esbenp.prettier-vscode","GitHub.copilot"]
}
}
// Uncomment to connect as root instead. More info: https://aka.ms/dev-containers-non-root.
// "remoteUser": "root"
}
5 changes: 3 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@ name: Build and Publish

on:
push:
branches:
- main
push:
tags:
- 'v*' # Push events to matching v*, i.e. v1.0, v20.15.10
release:
types:
- created
Expand Down
2 changes: 1 addition & 1 deletion .vscode/launch.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"outFiles": [
"${workspaceFolder}/out/**/*.js"
],
"preLaunchTask": "${defaultBuildTask}"
"preLaunchTask": "${defaultBuildTask}"
},
{
"name": "Extension Tests",
Expand Down
3 changes: 2 additions & 1 deletion .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@
"out": true // set this to false to include "out" folder in search results
},
// Turn off tsc task auto detection since we have the necessary tasks as npm scripts
"typescript.tsc.autoDetect": "off"
"typescript.tsc.autoDetect": "off",
"mcap.mcapPath": "mcap"
}
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"properties": {
"mcap.mcapPath": {
"type": "string",
"default": "/workspaces/foxglove-mcap/mcap",
"default": "mcap",
"description": "Complete functions with their parameter signature.",
"scope": "resource"
},
Expand Down
Loading

0 comments on commit 69d6389

Please sign in to comment.