Migrate Automatically Check for Updates toggle from About tab to General Tab #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jerry23011
requested review from
NeverAgain11,
choykarl,
tisfeng,
AkaShark,
CanglongCl and
phlpsong
AkaShark
previously approved these changes
Mar 6, 2024
tisfeng
requested changes
Mar 6, 2024
There was a problem hiding this comment.
I think it would be better to place the AutoCheckUpdate option on the General tab, because it is a common feature for most apps.
The advanced tab should place some less common features,, or features in Easydict that are not well understood by the average user.
tisfeng
requested changes
Mar 6, 2024
Jerry23011
force-pushed
the
update-migration
branch
from
938853a to
5ec1703
Compare
tisfeng
reviewed
Mar 9, 2024
phlpsong
approved these changes
Mar 10, 2024
tisfeng
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please tell me if I CVed the code right :)