Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle merge for websocket #31

Open
tirumaraiselvan opened this issue Jun 19, 2019 · 1 comment
Open

Handle merge for websocket #31

tirumaraiselvan opened this issue Jun 19, 2019 · 1 comment
Assignees
@tirumaraiselvan
Labels
e/medium

Comments

@tirumaraiselvan
Copy link
Owner

tirumaraiselvan commented Jun 19, 2019 •
edited
Loading

Currently, the websocket code doesn't combine results if there are more than one top level fields. This results in few test failures.
@jberryman
Copy link
Collaborator

I can take this one.

@tirumaraiselvan tirumaraiselvan self-assigned this Aug 13, 2019
jberryman added a commit that referenced this issue Aug 28, 2019
@jberryman
Merge pull request #46 from tirumaraiselvan/remote-relationships-v2-f…
b27eba5 
…ix-websocket

fix merge for websocket and misc (fix #31)
tirumaraiselvan pushed a commit that referenced this issue Apr 21, 2021
@hasura-bot @codingkarthik @jberryman
server: query remote server in a remote join query iff all arguments …
8eebcb9 
…are not null (#31)

* server: query remote server in a remote join query iff all arguments are not null

Co-authored-by: Karthikeyan Chinnakonda <karthikeyan@hasura.io>
GITHUB_PR_NUMBER: 6199
GITHUB_PR_URL: hasura#6199

* Update server/src-lib/Hasura/Backends/Postgres/Execute/RemoteJoin.hs

Co-authored-by: Brandon Simmons <brandon@hasura.io>

* Apply suggestions from code review

Co-authored-by: Brandon Simmons <brandon@hasura.io>

* Update server/tests-py/test_remote_relationships.py

Co-authored-by: Brandon Simmons <brandon@hasura.io>

* Apply suggestions from code review

Co-authored-by: Brandon Simmons <brandon@hasura.io>

* use guard instead of case match

* add comment about the remote relationship joining

* add a comment about the design discussion

* update CHANGELOG

Co-authored-by: Karthikeyan Chinnakonda <karthikeyan@hasura.io>
Co-authored-by: Brandon Simmons <brandon@hasura.io>
GitOrigin-RevId: ce7e828
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tirumaraiselvan tirumaraiselvan

Labels
e/medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jberryman @tirumaraiselvan