Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle errors from RemoteExecution #27

Open
tirumaraiselvan opened this issue Jun 18, 2019 · 3 comments
Open

Handle errors from RemoteExecution #27

tirumaraiselvan opened this issue Jun 18, 2019 · 3 comments
Assignees
@jberryman
Labels
e/medium

Comments

@tirumaraiselvan
Copy link
Owner

Currently only data key is looked for.
@tirumaraiselvan
Copy link
Owner Author

This has been fixed in many paths, yet few paths are remaining.

@jberryman
Copy link
Collaborator

Checking out a code coverage report might be useful here in tracking these places down. Haskell's laziness actually makes these even more revealing than they might be in a different language.

@jberryman
Copy link
Collaborator

I can take this one.

jberryman added a commit to jberryman/graphql-engine that referenced this issue Aug 19, 2019
@jberryman
WIP tirumaraiselvan#27
904f73d 
preserve remoteResp errors in insertBatchResults
misc renaming for clarity
some minor refactorings for brevity/clarity
TODO extractRemoteRelArguments
jberryman added a commit to jberryman/graphql-engine that referenced this issue Aug 20, 2019
@jberryman
WIP tirumaraiselvan#27
9b5b6f6 
preserve remoteResp errors in insertBatchResults
misc renaming for clarity
some minor refactorings for brevity/clarity
TODO extractRemoteRelArguments
jberryman added a commit to jberryman/graphql-engine that referenced this issue Aug 22, 2019
@jberryman
Preserve all response errors closes tirumaraiselvan#27
34ab5c0 
preserve remoteResp errors in insertBatchResults
misc renaming for clarity
some minor refactorings for brevity/clarity

simplify extractRemoteRelArguments which looked like something
half-implemented.
tirumaraiselvan added a commit that referenced this issue Apr 21, 2021
@hasura-bot @tirumaraiselvan
archive invalid events and drop existing invalid postgres triggers (#27)
e805156 
GITHUB_PR_NUMBER: 6181
GITHUB_PR_URL: hasura#6181

Co-authored-by: Tirumarai Selvan A <tiru@hasura.io>
GitOrigin-RevId: fdbc18a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jberryman jberryman

Labels
e/medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jberryman @tirumaraiselvan