This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
You can now supply email_required true to paymentRequestWithAndroidPay and email address will be added to extra.shippingAddress and extra.billingAddress in line with Apple pay.
Replaces: #279 which was out of date
Types of changes
What types of changes does your code introduce to
tipsi-stripe
?Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! Next steps are a reminder of what we are going to look at before merging your code.N/A to all - there's no tests that I know of and the docs are duplicated in three different places. I don't know which ones I am updating. Are they auto-generated somehow? Happy to add if I can be pointed to where.
Further comments
Simple change. Have introduced the option to request email or not which defaults to false and placed email in the shipping and billing fields instead of on its own to bring in line with IOS.