Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Google pay - capture email #469

Merged
merged 3 commits into from
Apr 21, 2019
Merged

Conversation

shokimble
Copy link
Contributor

@shokimble shokimble commented Apr 17, 2019

Proposed changes

You can now supply email_required true to paymentRequestWithAndroidPay and email address will be added to extra.shippingAddress and extra.billingAddress in line with Apple pay.

Replaces: #279 which was out of date

Types of changes

What types of changes does your code introduce to tipsi-stripe?
Put an x in the boxes that apply

  • Bugfix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! Next steps are a reminder of what we are going to look at before merging your code.

  • I have added tests that prove my fix is useful or that my feature works
  • I have added necessary documentation (if appropriate)
  • I know that my PR will be merged only if it has tests and they pass

N/A to all - there's no tests that I know of and the docs are duplicated in three different places. I don't know which ones I am updating. Are they auto-generated somehow? Happy to add if I can be pointed to where.

Further comments

Simple change. Have introduced the option to request email or not which defaults to false and placed email in the shipping and billing fields instead of on its own to bring in line with IOS.

@cybergrind cybergrind merged commit 39055a0 into tipsi:master Apr 21, 2019
@cybergrind
Copy link
Member

@shokimble thank you for your contribution and patience!

@shokimble
Copy link
Contributor Author

@cybergrind cheers for the merge. It helps me as much as anyone as I don't have to worry about my long out of date fork any longer 😋

@cybergrind
Copy link
Member

@shokimble that's why I believe merging your changes to master repository worths most of the efforts of it - someone else is going to maintain it =)

@harshvitra
Copy link

This doesn't work.
I'm not sure why but I'm not getting the email address

using as stated

@harshvitra
Copy link

@shokimble
Can you help me, the email field is not being asked from the user.
And neither returned in the token

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants