Added server_path, start FlaskServer and add host and port parameters #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hod start_server. Optimize part of the logic for starting flaskserver
# Conflicts: # tinyms/serving/server/server.py
leonwanghui
reviewed
Apr 16, 2021
leonwanghui
reviewed
Apr 16, 2021
leonwanghui
reviewed
Apr 16, 2021
leonwanghui
suggested changes
Apr 16, 2021
|
@Mickls Please fix the comments mentioned above, then I think it should be ok to go. |
…p.json file, and changed the host and port when creating the service to read the configuration file
I have made changes to the above modification suggestions, you can check my latest submission again |
Add a default value for serving_path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do / why do we need it:
Added server_path, start FlaskServer and add host and port parameters
Which issue(s) this PR fixes:
Fixes #62
Special notes for your reviewers: