TINY-8705: Adding extraBrowserCapabilities flag to bedrock-auto #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ephox-mogran
requested review from
spocke,
metricjs,
lnewson and
ltrouton
as code owners
spocke
approved these changes
May 10, 2022
spocke
approved these changes
May 10, 2022
lnewson
approved these changes
May 10, 2022
ltrouton
approved these changes
May 11, 2022
PR suggestions Co-authored-by: Lee Newson <lee.newson@tiny.cloud>
ephox-mogran
force-pushed
the
feature/TINY-8705
branch
from
0008880 to
849692d
Compare
lnewson
approved these changes
May 11, 2022
spocke
approved these changes
May 11, 2022
| @@ -67,6 +69,15 @@ const addArguments = (capabilities: Record<string, any>, name: string, args: str | |||
| capabilities[name].args = currentArgs.concat(args); | |||
| }; | |||
|
|
|||
| const getExtraBrowserCapabilities = (settings: DriverSettings): string[] => { | |||
| const extraCaps = settings.extraBrowserCapabilities.trim(); | |||
| if (extraCaps.length > 0) { | |||
There was a problem hiding this comment.
I thought it wasn't commonly used. I don't know what style to use any more. I'm just trying to fit in :)
There was a problem hiding this comment.
I was also surprised by this tbh 😂 I don't think we have a standard much anymore for this 😞
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.