-
Notifications
You must be signed in to change notification settings - Fork 890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wasm-unknown target shouldn't set --import-memory
by default
#4319
Labels
wasm
WebAssembly
Comments
Because wasm-unknown by default doesn't target a particular platform, it's difficult to say whether memory should be imported or exported by default. |
I think @jmillikin is probably correct in what the default should be. |
See #4414 for a correction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
wasm-unknown
target invokeswasm-ld
with the--import-memory
option, which causes the following import to be emitted in the output:This is undesirable to have as default behavior for
wasm-unknown
, because it introduces a mandatory import into what is otherwise a freestanding module.If the
--import-memory
were to be removed fromtargets/wasm-unknown.json
ldflags, thenwasm-ld
would emit this instead:This option appears to have been added as part of a larger change in 2cd966d, but it's unclear from the commit message why
--import-memory
was added. Based on discussion in the PR, I think it was simply to reduce the number of bytes in an absolute bare-bones "hello world" module, which IMO is not a compelling reason to have it set by default.The text was updated successfully, but these errors were encountered: