-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to .NET Core 3.0 #17
Comments
Should help with tintoy/msbuild-project-tools-vscode#42. |
https://github.com/tintoy/msbuild-project-tools-vscode/releases/tag/v0.3.1 Hi - @divinebovine @mateusdeap, are you able to try this new build to see if it works for you? It's now built against .NET Core 3.x. |
@tintoy should it be showing up when I try to check for extension updates in vscode? Because it doesn't show up. Or do I need to install it by VSIX? |
By VSIX - I want to make sure it actually works for others before I publish it more widely :) |
In the meanwhile I'm going to try to enhance the extension as well so it can do a better job of reporting when the language server can't be launched. |
Published v0.3.2 - the extension should now provide more useful information if the language server cannot be started. |
@tintoy Ok, so I tested the extension. Everything seems to be just fine. I just had one issue, but I'm unsure if it's a bug: |
That's been an issue for quite some time now. Should be unrelated to .NET Core 3.0 |
Sorry, this one has fallen off radar :) I’ll look into it this afternoon... |
No worries mate. Just wanted let you know before you go yak shaving on .NET Core 3.0 for no reason 😄 |
That's on VSCode v1.39.2. |
Hmmm. I guess I'll check my VS Code version later and test it. Either way, I think this issue can be considered closed, since the upgrade has been done. Thanks a bunch! :D |
Now that 3.0 is out, we should upgrade the language server to target
netcoreapp3.0
.This means consumers will need either the 3.0 SDK or the 3.0 runtime if they don’t want to upgrade to the 3.0 SDK yet.
May need to be careful about verifying that this doesn’t affect behaviour of the MSBuild engine at runtime.
The text was updated successfully, but these errors were encountered: