Remove WorkflowData API #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdoherty4
force-pushed
the
feat/remove-workflow-data
branch
from
56f3cee to
08552a8
Compare
Codecov Report
@@ Coverage Diff @@
## main #650 +/- ##
==========================================
- Coverage 45.09% 45.06% -0.04%
==========================================
Files 62 61 -1
Lines 3559 3557 -2
==========================================
- Hits 1605 1603 -2
Misses 1872 1872
Partials 82 82 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
chrisdoherty4
force-pushed
the
feat/remove-workflow-data
branch
2 times, most recently
from
582a594 to
b9a72a1
Compare
chrisdoherty4
force-pushed
the
feat/remove-workflow-data
branch
from
f0bba8f to
35dc781
Compare
chrisdoherty4
force-pushed
the
feat/remove-workflow-data
branch
from
f11fa40 to
56f3cee
Compare
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
chrisdoherty4
force-pushed
the
feat/remove-workflow-data
branch
from
527294f to
a459ded
Compare
The WorkflowData API relates to multi worker workflows that aren't implemented in the Kube backend. With the move to the Kube backend we're taking the opportunity to reset and implement this sanely when its needed, not before. Signed-off-by: Chris Doherty <chris.doherty4@gmail.com>
chrisdoherty4
force-pushed
the
feat/remove-workflow-data
branch
from
a459ded to
6d7dea7
Compare
displague
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WorkflowData API relates to multi worker workflows that aren't implemented in the Kube backend. With the move to the Kube backend we're taking the opportunity to reset and implement this sanely when its needed, not before.