detectPublicIPv4: try to detect ipv4's from interfaces with a default gateway first #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpardini
force-pushed
the
autodetect-ip4v-with-default-gateway
branch
from
269c9d8 to
f4e2a80
Compare
… gateway first - adds github.com/vishvananda/netlink to get at the routing tables - if none found, old logic is kept (gets the first IPv4 from the first interface that has one) Signed-off-by: Ricardo Pardini <ricardo@pardini.net>
rpardini
force-pushed
the
autodetect-ip4v-with-default-gateway
branch
from
f4e2a80 to
c746cb9
Compare
|
Yay got it green, finally. Sorry for the delay... |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #493 +/- ##
===================================
- Coverage 52% 52% -1%
===================================
Files 26 26
Lines 2116 2136 +20
===================================
+ Hits 1121 1124 +3
- Misses 963 980 +17
Partials 32 32 ☔ View full report in Codecov by Sentry. |
jacobweinstock
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
detectPublicIPv4: try to detect ipv4's from interfaces with a default gateway first
Signed-off-by: Ricardo Pardini ricardo@pardini.net