Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes DHCP and removes BPFilter #44

Merged
merged 2 commits into from
Mar 22, 2021
Merged

Conversation

thebsdbox
Copy link
Contributor

Description

Fixes DHCP in hook.yaml
Removes BPFilter in kernel

Why is this needed

Improves reliability and reduces time to boot.

Fixes: #

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

@thebsdbox thebsdbox requested a review from gianarb March 19, 2021 15:29
@thebsdbox thebsdbox added AWESOMENESS kind/feature Categorizes issue or PR as related to a new feature. labels Mar 19, 2021
Signed-off-by: Dan Finneran <dan@thebsdbox.co.uk>
@thebsdbox
Copy link
Contributor Author

Fixes #43

@detiber
Copy link
Contributor

detiber commented Mar 19, 2021

I was hoping to download the artifact from the CI job, but it looks like it failed to upload (without a failure sadly), testing locally it looks like the working directory is dirty after building the image, causing the image name to also have dirty in it. Might need to add /dist to .gitignore to prevent that.

@displague
Copy link
Member

I see other configs are enabled as modules, is the initrd for this kernel produced as well?
Any reason to enable the bpf module (modularly)?

@thebsdbox
Copy link
Contributor Author

Yeah, it's a good point. I only removed the bpfilter include as it was a blocking init process by the kernel and adds a few seconds before init starts. I don't know how deep we want to go diverging from the default config upstream to having our own truly optimised kernel.

We could perhaps make significant savings in memory usage from the initramdisk if we go into "deep" into the hornets nest of kconfig.

@gianarb gianarb removed their request for review March 22, 2021 08:34
@gianarb gianarb added the ready-to-merge Signal to Mergify to merge the PR. label Mar 22, 2021
@mergify mergify bot merged commit bc3e58a into tinkerbell:main Mar 22, 2021
@thebsdbox thebsdbox deleted the kernel_dhcp branch April 5, 2021 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AWESOMENESS kind/feature Categorizes issue or PR as related to a new feature. ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants