Fixes for #130 which was fixes for #105 #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Publishing has been temporarily dropped. Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>
Linuxkit seems to mount the file as read-only which causes hook-docker to not be able to overwrite the file. I messed around with adding :rw and converting to a full `mount` to try and make it rw, but nothing worked. So far we don't actually need to bind-mount the file so we can just punt on this until later. Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>
ScottGarman
approved these changes
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
make deploywhich was deleted.Why is this needed
Fixes CI and dbg runs.
How Has This Been Tested?
CI fix should just work.
I've been running with the daemon.json drop in a different branch and thought it was in branch for #130.
How are existing users impacted? What migration steps/scripts do we need?
CI is ✔️ not ❌ which makes us all feel warm and fuzzy.
dbg builds are actually useful and work.