Skip to content

Commit

Permalink
Revert update of libgit2
Browse files Browse the repository at this point in the history
Unfortunately this flew past on the bots because we didn't built on one of the
10.7 bots, but it looks like libgit2 doesn't currently build on OSX 10.7 so
we'll have to wait until that's fixed to update.
  • Loading branch information
alexcrichton committed Aug 17, 2015
1 parent d48f89d commit 6bf1642
Show file tree
Hide file tree
Showing 6 changed files with 25 additions and 28 deletions.
17 changes: 8 additions & 9 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,12 @@ docopt = "0.6"
env_logger = "0.3"
filetime = "0.1"
flate2 = "0.2"
git2 = "0.3"
git2-curl = "0.3"
git2 = "0.2"
git2-curl = "0.2"
glob = "0.2"
kernel32-sys = "0.1"
libc = "0.1"
libgit2-sys = "0.3"
libgit2-sys = "0.2"
log = "0.3"
num_cpus = "0.2"
regex = "0.1"
Expand Down
9 changes: 4 additions & 5 deletions src/cargo/sources/git/utils.rs
Original file line number Diff line number Diff line change
Expand Up @@ -413,11 +413,10 @@ pub fn fetch(repo: &git2::Repository, url: &str,
with_authentication(url, &try!(repo.config()), |f| {
let mut cb = git2::RemoteCallbacks::new();
cb.credentials(f);
let mut remote = try!(repo.remote_anonymous(&url));
let mut opts = git2::FetchOptions::new();
opts.remote_callbacks(cb)
.download_tags(git2::AutotagOption::All);
try!(remote.fetch(&[refspec], Some(&mut opts), None));
let mut remote = try!(repo.remote_anonymous(&url, Some(refspec)));
try!(remote.add_fetch("refs/tags/*:refs/tags/*"));
remote.set_callbacks(cb);
try!(remote.fetch(&["refs/tags/*:refs/tags/*", refspec], None));
Ok(())
})
}
5 changes: 3 additions & 2 deletions tests/support/git.rs
Original file line number Diff line number Diff line change
Expand Up @@ -97,9 +97,10 @@ pub fn add_submodule<'a>(repo: &'a git2::Repository, url: &str,
let path = path.to_str().unwrap().replace(r"\", "/");
let mut s = repo.submodule(url, Path::new(&path), false).unwrap();
let subrepo = s.open().unwrap();
subrepo.remote_add_fetch("origin", "refs/heads/*:refs/heads/*").unwrap();
let mut origin = subrepo.find_remote("origin").unwrap();
origin.fetch(&[], None, None).unwrap();
origin.add_fetch("refs/heads/*:refs/heads/*").unwrap();
origin.fetch(&[], None).unwrap();
origin.save().unwrap();
subrepo.checkout_head(None).unwrap();
s.add_finalize().unwrap();
return s;
Expand Down
6 changes: 2 additions & 4 deletions tests/test_cargo_build_auth.rs
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ test!(http_auth_offered {
assert_eq!(req, vec![
"GET /foo/bar/info/refs?service=git-upload-pack HTTP/1.1",
"Accept: */*",
"User-Agent: git/1.0 (libgit2 0.23.0)",
"User-Agent: git/1.0 (libgit2 0.22.0)",
].into_iter().map(|s| s.to_string()).collect());
drop(s);

Expand All @@ -55,7 +55,7 @@ test!(http_auth_offered {
"GET /foo/bar/info/refs?service=git-upload-pack HTTP/1.1",
"Authorization: Basic Zm9vOmJhcg==",
"Accept: */*",
"User-Agent: git/1.0 (libgit2 0.23.0)",
"User-Agent: git/1.0 (libgit2 0.22.0)",
].into_iter().map(|s| s.to_string()).collect());
});

Expand Down Expand Up @@ -155,8 +155,6 @@ Caused by:
addr = addr,
errmsg = if cfg!(windows) {
"[[..]] failed to send request: [..]\n"
} else if cfg!(target_os = "macos") {
"[[..]] unexpected return value from ssl handshake [..]"
} else {
"[[..]] SSL error: [..]"
})));
Expand Down
10 changes: 5 additions & 5 deletions tests/test_cargo_compile_git_deps.rs
Original file line number Diff line number Diff line change
Expand Up @@ -921,12 +921,12 @@ test!(dep_with_changed_submodule {
sub.sync().unwrap();
{
let subrepo = sub.open().unwrap();
subrepo.remote_add_fetch("origin",
"refs/heads/*:refs/heads/*").unwrap();
subrepo.remote_set_url("origin",
&git_project3.url().to_string()).unwrap();
let mut origin = subrepo.find_remote("origin").unwrap();
origin.fetch(&[], None, None).unwrap();
origin.set_url(&git_project3.url().to_string()).unwrap();
origin.add_fetch("refs/heads/*:refs/heads/*").unwrap();;
origin.fetch(&[], None).unwrap();
origin.save().unwrap();

let id = subrepo.refname_to_id("refs/remotes/origin/master").unwrap();
let obj = subrepo.find_object(id, None).unwrap();
subrepo.reset(&obj, git2::ResetType::Hard, None).unwrap();
Expand Down

0 comments on commit 6bf1642

Please sign in to comment.