Skip to content

Commit

Permalink
update cran-comments prior to submission
Browse files Browse the repository at this point in the history
  • Loading branch information
timyers committed May 11, 2022
1 parent 22524e4 commit 9a96d6b
Showing 1 changed file with 14 additions and 13 deletions.
27 changes: 14 additions & 13 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,21 +1,22 @@
## Submission of the fifth release
* Responding to feedback from CRAN:
* 'Packages which use Internet resources should fail gracefully with an informative message if the resource is not available or has changed (and not give a check warning nor error).'
* Action taken in response:
* Code chunk in vignette example no longer requires Internet resources.
* Included code in package functions to check status of Internet resources and use informative message if not available.
* Other minor changes

Thank you for finding this oversight and for reviewing my submission!
## Submission of the 6th release
* Fix status NOTE about LazyData in CRAN package check results
* Add new argument to each function to support different genome builds
* Add new argument to `LDhap` (table_type) - Issue #13
* Fix `LDhap` valid input check for number of input 'snps' - Issue #14
* Improve/update error and warning message returned in the response data
* Add support for new genotyping chips in function `SNPchip`
* Update vignette and README
* Miscellaneous minor changes

## Test environments
* local R installation, R 4.0.3
* local R installation, R 4.1.2, MacOS Monterey v.12.3.1
* win-builder (devel, release, oldrelease)
* Rhub
* Windows Server 2008 R2 SP1, R-devel, 32/64 bit
* Oracle Solaris 10, x86, 32 bit, R-release
* Windows Server 2022, R-devel, 64 bit
* Ubuntu Linux 20.04.1 LTS, R-release, GCC
* Fedora Linux, R-devel, GCC
* Fedora Linux, R-devel, clang, gfortran
* Debian Linux, R-devel, clang, ISO-8859-15 locale
* Apple Silicon (M1), macOS 11.6 Big Sur, R-release

## R CMD check results

Expand Down

0 comments on commit 9a96d6b

Please sign in to comment.