Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add field descriptions to table #66

Open
timwis opened this issue Sep 11, 2015 · 6 comments
Open

Add field descriptions to table #66

timwis opened this issue Sep 11, 2015 · 6 comments

Comments

@timwis
Copy link
Owner

timwis commented Sep 11, 2015

No description provided.

marks pushed a commit to marks/vizwit that referenced this issue Jan 18, 2016
timwis#66 first pass at adding tooltips
4f9b469 
is quite a hack.. need to understand where to put the code added to
socrata-fields.js
@marks
Copy link
Collaborator

marks commented Jan 18, 2016

@timwis something like this?

business_licenses_in_chicago_-_vizwit

marks pushed a commit to marks/vizwit that referenced this issue Jan 18, 2016
timwis#66 add check for blank description
4fcbddc
@timwis
Copy link
Owner Author

timwis commented Jan 20, 2016

That's perfect. What's the source? Pulling from the fields collection or being defined in the config?

@marks
Copy link
Collaborator

marks commented Jan 21, 2016

@timwis this is specific to the Socrata provider but it would work if other providers pass a description key (and value) with each column

marks pushed a commit to marks/vizwit that referenced this issue Jan 21, 2016
timwis#66 fix lint nits
ba5d83d
@timwis
Copy link
Owner Author

timwis commented Jan 21, 2016

Sounds great - can you submit a PR on the table view? Note that #149 has some changes to the table view

@marks
Copy link
Collaborator

marks commented Jan 21, 2016

@timwis any idea when #149 will get merged or should I work off that branch in anticipation? Maybe I'm lazy but I'd rather wait for #149 to be merged first

@timwis
Copy link
Owner Author

timwis commented Jan 21, 2016

I'll merge it now

marks pushed a commit to marks/vizwit that referenced this issue Jan 22, 2016
timwis#66 redid work after merge
269c302
timwis added a commit that referenced this issue Jan 22, 2016
@timwis
Merge pull request #157 from marks/66-add-field-description
cbfb25b 
#66 add field description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marks @timwis