add mkdocs-drawio plugin support #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was on holiday for a while, back now :) This looks fine, thanks for taking the effort! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Support printing drawio diagrams. The diagram rendering happens in
on_post_pagewhich is skipped by this plugin and therefore we explicitly need to add support formkdocs-drawiofor printing drawio diagrams.More details
Details regarding the implementation and reasoning can be found here: #99
The latest version of
mkdocs-drawio1.6.0adds support for printing with this plugin.tuunit/mkdocs-drawio@b26a7f3
How has this been tested
I've added the
mkdocs-print-site-pluginto the example directory inmkdocs-drawioand tested the/print_page/endpoint and PDF generation: