Merge pull request #63 from timvink/60_disable_lazy_loading

Attempt to disable lazy loading
timvink · Jan 14, 2022 · c6c4b51 · c6c4b51
2 parents 52fd293 + 13c0ced
commit c6c4b51
Show file tree

Hide file tree

Showing 6 changed files with 25 additions and 5 deletions.
diff --git a/mkdocs_print_site_plugin/js/print-site.js b/mkdocs_print_site_plugin/js/print-site.js
@@ -146,4 +146,4 @@ function remove_element_by_classname(class_name) {
   if( el.length > 0) {
     el[0].style.display = "none"
   }
-}
+}
diff --git a/mkdocs_print_site_plugin/plugin.py b/mkdocs_print_site_plugin/plugin.py
@@ -309,6 +309,10 @@ def on_post_build(self, config, **kwargs):
         # Render the theme template for the print page
         html = template.render(self.context)
 
+        # Remove lazy loading attributes from images
+        # https://regex101.com/r/HVpKPs/1
+        html = re.sub(r"(\<img.+)(loading=\"lazy\")", r"\1", html)        
+
         # Compatiblity with mkdocs-chart-plugin
         # As this plugin adds some javascript to every page
         # It should be included in the print site also

diff --git a/setup.py b/setup.py
@@ -9,7 +9,7 @@
 
 setup(
     name="mkdocs-print-site-plugin",
-    version="2.2.3",
+    version="2.2.4",
     description="MkDocs plugin that combines all pages into one, allowing for easy export to PDF and standalone HTML.",
     long_description=long_description,
     long_description_content_type="text/markdown",

diff --git a/tests/fixtures/projects/basic/docs/index.md b/tests/fixtures/projects/basic/docs/index.md
@@ -9,4 +9,12 @@ An to an anchor on page A [link](a.md#anchor-links)
 
 ## Subsection
 
-On the homepage
+On the homepage
+
+## An image with lazy loading
+
+See https://github.com/timvink/mkdocs-print-site-plugin/issues/60 
+
+![Image title](https://dummyimage.com/600x400/){ loading=lazy }
+
+
diff --git a/tests/fixtures/projects/basic/mkdocs_material_instant_loading.yml b/tests/fixtures/projects/basic/mkdocs_material_instant_loading.yml
@@ -13,4 +13,8 @@ plugins:
 nav:
     - Home: index.md
     - Page Z: z.md
-    - Page A: a.md
+    - Page A: a.md
+
+markdown_extensions:
+  - attr_list
+  - md_in_html
diff --git a/tests/fixtures/projects/basic/mkdocs_material_with_git_plugin.yml b/tests/fixtures/projects/basic/mkdocs_material_with_git_plugin.yml
@@ -12,4 +12,8 @@ plugins:
 nav:
     - Home: index.md
     - Page Z: z.md
-    - Page A: a.md
+    - Page A: a.md
+
+markdown_extensions:
+  - attr_list
+  - md_in_html
-Original file line number
+Diff line change
@@ Expand Up / @@ -146,4 +146,4 @@ function remove_element_by_classname(class_name) { @@
       if( el.length > 0) {
         el[0].style.display = "none"
       }
-    }
+    }