Skip to content

Commit

Permalink
Disable network connections to Contile for the tests
Browse files Browse the repository at this point in the history
In PR mozilla#18356 the new tab page logic was disabled to prevent Firefox
from logging failed network connections to Contile, the Mozilla Tiles
service that is used for the new tab page [1]. However, recently this
log reappeared locally and on the bots:

```
console.warn: TopSitesFeed: Failed to fetch data from Contile server:
NetworkError when attempting to fetch resource.
```

It looks like Contile communication is also triggered from other places
in Firefox such as the URL bar [2], so this commit fixes the issue by
disabling network connections to Contile [3] altogether regardless of
their origin within Firefox. Note that we don't revert the change from
PR mozilla#18356 because as noted in [4] it can't hurt to keep that disabled
too to avoid overhead for a feature we don't use in the tests.

[1] https://github.com/mozilla-services/contile
[2] https://github.com/mozilla/gecko-dev/blob/196ef8360e4d3b5c334f1f8f91b3b1fdb434eb63/browser/components/urlbar/UrlbarProviderTopSites.sys.mjs#L38
[3] https://github.com/mozilla/gecko-dev/blob/196ef8360e4d3b5c334f1f8f91b3b1fdb434eb63/browser/components/newtab/lib/TopSitesFeed.sys.mjs#L111
[4] mozilla#18356 (comment)
  • Loading branch information
timvandermeij committed Jul 13, 2024
1 parent 07c58aa commit aea409d
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions test/test.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -944,6 +944,8 @@ async function startBrowser({
"accessibility.browsewithcaret": true,
// Disable the newtabpage stuff.
"browser.newtabpage.enabled": false,
// Disable network connections to Contile.
"browser.topsites.contile.enabled": false,
...extraPrefsFirefox,
};
}
Expand Down

0 comments on commit aea409d

Please sign in to comment.