Statically prevent matching the empty string #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xaionaro ok. this should prevent putting in tokens which match the empty string. Let me know if it works for you. |
timtadh
changed the title
|
@timtadh yep, works, thanks) |
Signed-off-by: Tim Henderson <tadh@google.com>
Signed-off-by: Tim Henderson <tadh@google.com>
timtadh
force-pushed
the
no-empty-strings
branch
from
939abe5 to
9bc5e2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in response to #22 and #20 this prevents compilation of patterns which match the empty strings. At the moment it does not determine the exact pattern which is responsible for matching the empty string. That would be a good project (and I would welcome the contribution!!).