Fixes DFA/NFA returning incorrect tc in some cases #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Henderson <tadh@google.com>
Signed-off-by: Tim Henderson <tadh@google.com>
|
@ty2 let me know if this helpful. |
Signed-off-by: Tim Henderson <tim.tadh@gmail.com>
This is a bug in the DFA backend there may be something similar in the NFA backend as well. More testing required. Signed-off-by: Tim Henderson <tim.tadh@gmail.com>
this is the corresponding fix for the NFA backend Signed-off-by: Tim Henderson <tim.tadh@gmail.com>
timtadh
changed the title
|
Thanks. 😘 |
Signed-off-by: Tim Henderson <tadh@google.com>
Signed-off-by: Tim Henderson <tadh@google.com>
|
@xaionaro this should now error if an empty string is matched. I will add the static checking as a separate pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to #20 I added some test for python style strings to ensure that lexmachine can properly lex them now and in the future.