simplify rdstdin (nim-lang#18382)

timotheecour · Jun 28, 2021 · 6387e28 · 6387e28
1 parent 808db3b
commit 6387e28
Showing 1 changed file with 4 additions and 10 deletions.
diff --git a/lib/impure/rdstdin.nim b/lib/impure/rdstdin.nim
@@ -52,16 +52,6 @@ elif defined(genode):
 else:
   import linenoise
 
-  proc readLineFromStdin*(prompt: string): string {.
-                          tags: [ReadIOEffect, WriteIOEffect].} =
-    var buffer = linenoise.readLine(prompt)
-    if isNil(buffer):
-      raise newException(IOError, "Linenoise returned nil")
-    result = $buffer
-    if result.len > 0:
-      historyAdd(buffer)
-    linenoise.free(buffer)
-
   proc readLineFromStdin*(prompt: string, line: var string): bool {.
                           tags: [ReadIOEffect, WriteIOEffect].} =
     var buffer = linenoise.readLine(prompt)
@@ -73,3 +63,7 @@ else:
       historyAdd(buffer)
     linenoise.free(buffer)
     result = true
+
+  proc readLineFromStdin*(prompt: string): string {.inline.} =
+    if not readLineFromStdin(prompt, result):
+      raise newException(IOError, "Linenoise returned nil")