Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fixtures references #532

Merged
merged 7 commits into from
May 4, 2023
Merged

Remove fixtures references #532

merged 7 commits into from
May 4, 2023

Conversation

smaye81
Copy link
Collaborator

@smaye81 smaye81 commented May 4, 2023

This removes the concept of fixtures from the repo by doing the following:

  • Remove all fixture files from packages/test-fixtures.
  • Rename packages/test-fixtures to packages/proto.
  • Update all references to test-fixtures to use proto.
  • Generate descriptorSet for the helper in packages/plugin in that directory rather than using an external package as a dep.
  • Update docs

Note: as a follow on, we can convert usages of protoc to buf generate or buf build.

@smaye81 smaye81 requested a review from timostamm May 4, 2023 02:57
Copy link
Owner

@timostamm timostamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 just one nit about formatting in the manual.

packages/README.md Outdated Show resolved Hide resolved
packages/proto/.gitignore Outdated Show resolved Hide resolved
MANUAL.md Outdated Show resolved Hide resolved
Copy link
Owner

@timostamm timostamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@smaye81 smaye81 merged commit ded8791 into main May 4, 2023
@smaye81 smaye81 deleted the sayers/remove_fixtures branch May 4, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants