Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid overwriting a set oneof field in target with an unset oneof field in source #395

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

jcready
Copy link
Contributor

@jcready jcready commented Nov 11, 2022

Fixes: #386

Copy link
Owner

@timostamm timostamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@timostamm
Copy link
Owner

timostamm commented Nov 16, 2022

Released in v2.8.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reflectionMergePartial() will overwrite target oneof field even if source has none set
2 participants