Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] use new timing api #311

Closed
wants to merge 3 commits into from
Closed

Conversation

vilterp
Copy link

@vilterp vilterp commented Nov 17, 2022

introduced in JuliaLang/julia#47615

cc @NHDaly

@NHDaly NHDaly self-requested a review November 17, 2022 21:23
@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Base: 85.47% // Head: 17.90% // Decreases project coverage by -67.57% ⚠️

Coverage data is based on head (6d6d277) compared to base (ad792af).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head 6d6d277 differs from pull request most recent head 3e19101. Consider uploading reports for the commit 3e19101 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #311       +/-   ##
===========================================
- Coverage   85.47%   17.90%   -67.58%     
===========================================
  Files          17       16        -1     
  Lines        2162     1849      -313     
===========================================
- Hits         1848      331     -1517     
- Misses        314     1518     +1204     
Impacted Files Coverage Δ
SnoopCompileCore/src/snoopi_deep.jl 0.00% <0.00%> (-92.00%) ⬇️
SnoopPrecompile/src/SnoopPrecompile.jl 56.25% <ø> (-31.25%) ⬇️
SnoopCompileCore/src/snoopl.jl 0.00% <0.00%> (-100.00%) ⬇️
src/parcel_snoopl.jl 0.00% <0.00%> (-90.00%) ⬇️
src/parcel_snoopi_deep.jl 0.00% <0.00%> (-89.91%) ⬇️
src/invalidation_and_inference.jl 0.00% <0.00%> (-89.66%) ⬇️
src/invalidations.jl 0.00% <0.00%> (-83.92%) ⬇️
src/deep_demos.jl 0.00% <0.00%> (-58.98%) ⬇️
src/SnoopCompile.jl 66.66% <0.00%> (-33.34%) ⬇️
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@NHDaly
Copy link
Collaborator

NHDaly commented Dec 31, 2022

I think this can be closed in favor of #313 now, yeah?

@vilterp vilterp closed this Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants