Add TOML to list of stdlibs for Julia v1.6 #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know what would happen if it were there with no TOML module, but this looks fine. Thanks for the contribution! |
jmert
added a commit
to jmert/julia
that referenced
this pull request
Nov 15, 2020
This doesn't make PRs like timholy/Revise.jl#522, timholy/Revise.jl#534, timholy/Revise.jl#553, etc unnecessary since that will still be required if you want to revise a stdlib while working normally from the REPL, but this at least makes a quick `make test-revise-complex` to work where you're trying out unrelated changes to the as-yet unknown standard libraries. Before: ```julia $ make test-revise-complex JULIA test/revise-complex ERROR: LoadError: no Revise.track recipe for module NetworkOptions Stacktrace: [1] error(::String, ::Symbol) @ Base ./error.jl:42 [2] _track(id::Base.PkgId, modname::Symbol; modified_files::Set{Tuple{Revise.PkgData, String}}) @ Revise ~/.julia/packages/Revise/fwStr/src/recipes.jl:105 ... ``` After: ```julia $ make test-revise-complex JULIA test/revise-complex WARNING: redefinition of constant _clipboard_copy. This may fail, cause incorrect answers, or produce other errors. WARNING: redefinition of constant _clipboard_paste. This may fail, cause incorrect answers, or produce other errors. ┌ Warning: skipping callee #wait#19 (called by wait) due to UndefVarError(:WindowsRawSocket) └ @ LoweredCodeUtils ~/.julia/packages/LoweredCodeUtils/cquzG/src/signatures.jl:279 Test (Worker) | Time (s) | GC (s) | GC % | Alloc (MB) | RSS (MB) complex (1) | started at 2020-11-15T12:06:27.051 complex (1) | 17.83 | 0.29 | 1.6 | 1338.02 | 592.97 Test Summary: | Pass Broken Total Overall | 8410 5 8415 SUCCESS ```
Keno
pushed a commit
to JuliaLang/julia
that referenced
this pull request
Nov 26, 2020
This doesn't make PRs like timholy/Revise.jl#522, timholy/Revise.jl#534, timholy/Revise.jl#553, etc unnecessary since that will still be required if you want to revise a stdlib while working normally from the REPL, but this at least makes a quick `make test-revise-complex` to work where you're trying out unrelated changes to the as-yet unknown standard libraries. Before: ```julia $ make test-revise-complex JULIA test/revise-complex ERROR: LoadError: no Revise.track recipe for module NetworkOptions Stacktrace: [1] error(::String, ::Symbol) @ Base ./error.jl:42 [2] _track(id::Base.PkgId, modname::Symbol; modified_files::Set{Tuple{Revise.PkgData, String}}) @ Revise ~/.julia/packages/Revise/fwStr/src/recipes.jl:105 ... ``` After: ```julia $ make test-revise-complex JULIA test/revise-complex WARNING: redefinition of constant _clipboard_copy. This may fail, cause incorrect answers, or produce other errors. WARNING: redefinition of constant _clipboard_paste. This may fail, cause incorrect answers, or produce other errors. ┌ Warning: skipping callee #wait#19 (called by wait) due to UndefVarError(:WindowsRawSocket) └ @ LoweredCodeUtils ~/.julia/packages/LoweredCodeUtils/cquzG/src/signatures.jl:279 Test (Worker) | Time (s) | GC (s) | GC % | Alloc (MB) | RSS (MB) complex (1) | started at 2020-11-15T12:06:27.051 complex (1) | 17.83 | 0.29 | 1.6 | 1338.02 | 592.97 Test Summary: | Pass Broken Total Overall | 8410 5 8415 SUCCESS ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, I encountered the following while trying to test-revise part of Julia:
I'm not sure if having
:TOMLadded to the set conditional on the Julia version is what you want or not, so I can easily switch that to just a simple insert into the list if preferred.