-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add multiple features #58
Merged
timetheoretical
merged 25 commits into
timetheoretical:master
from
DanielHabenicht:wip/meeting-planner
Jul 9, 2022
Merged
add multiple features #58
timetheoretical
merged 25 commits into
timetheoretical:master
from
DanielHabenicht:wip/meeting-planner
Jul 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added an introductory note that describes the additions available with this fork
we renamed the file earlier and missed this reference
* remove unecessary code comments * remove unused code * undo previous phone number changes
so they dont capture sentences with dots at the end
Hey @DanielHabenicht and @fmuscetra , thanks a lot for this -- really nice work! I will accept this into the main branch. However, I will only be able to write update notes and generate new installer files in August. |
This was referenced Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there @timetheoretical, thanks for developing this plugin.
I am a colleague of fmuscetra.
We upgraded the Plugin a fair bit and I wanted to share what we've done.
I tried to make all changes as adaptive as possible so it can be reused in public.
Here they are:
Breaking:
Changed the .dll and Registry Entries to not contain spaces anymore. ("Jitsi Meet Outlook Add-In" => "JitsiMeetOutlookAddIn").
(There was an issue with Spaces at our side :D)
Enhancements:
I don't have much time from work to split this up into multiple PRs. So I am sorry for it being so big.