Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add multiple features #58

Merged

Conversation

DanielHabenicht
Copy link
Contributor

@DanielHabenicht DanielHabenicht commented Jul 5, 2022

Hi there @timetheoretical, thanks for developing this plugin.

I am a colleague of fmuscetra.
We upgraded the Plugin a fair bit and I wanted to share what we've done.

I tried to make all changes as adaptive as possible so it can be reused in public.

Here they are:

Breaking:
Changed the .dll and Registry Entries to not contain spaces anymore. ("Jitsi Meet Outlook Add-In" => "JitsiMeetOutlookAddIn").
(There was an issue with Spaces at our side :D)

Enhancements:

I don't have much time from work to split this up into multiple PRs. So I am sorry for it being so big.

@timetheoretical
Copy link
Owner

Hey @DanielHabenicht and @fmuscetra , thanks a lot for this -- really nice work!

I will accept this into the main branch. However, I will only be able to write update notes and generate new installer files in August.

@timetheoretical timetheoretical merged commit 0b8bbbd into timetheoretical:master Jul 9, 2022
@DanielHabenicht DanielHabenicht deleted the wip/meeting-planner branch July 19, 2022 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants