-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use OpenSSL 3.1.4 for OS X builds #6470
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6470 +/- ##
==========================================
- Coverage 87.34% 87.33% -0.02%
==========================================
Files 187 187
Lines 41869 41823 -46
Branches 9320 9300 -20
==========================================
- Hits 36571 36526 -45
+ Misses 3625 3621 -4
- Partials 1673 1676 +3 ☔ View full report in Codecov by Sentry. |
jnidzwetzki
force-pushed
the
osx_ssl
branch
8 times, most recently
from
December 24, 2023 11:24
1690ca1
to
2bafda8
Compare
jnidzwetzki
added
ci
force-auto-backport
Automatically backport this PR or fix of this issue, even if it's not marked as "bug"
labels
Dec 24, 2023
@gayyappan, @akuzm: please review this pull request.
|
This patch changes the OpenSSL version for the OS X builds to 3.1.4 since recent PostgreSQL versions contain a bug in the SSL handling and crash on OS X when OpenSSL 3.2.0 is used. See: Homebrew/homebrew-core#155651
antekresic
approved these changes
Dec 24, 2023
fabriziomello
approved these changes
Dec 26, 2023
Automated backport to 2.13.x not done: cherry-pick failed. Git status
|
timescale-automation
added
auto-backport-not-done
Automated backport of this PR has failed non-retriably (e.g. conflicts)
backported-2.13.x
labels
Dec 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport-not-done
Automated backport of this PR has failed non-retriably (e.g. conflicts)
backported-2.13.x
ci
force-auto-backport
Automatically backport this PR or fix of this issue, even if it's not marked as "bug"
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes the OpenSSL version for the OS X builds to 3.1.4,
since recent PostgreSQL versions contain a bug in the SSL handling and
crash on OS X when OpenSSL 3.2.0 is used.
See: Homebrew/homebrew-core#155651
This also fixes the build problem in our 2.13.x branch
Link to current CI failures: https://github.com/timescale/timescaledb/actions/runs/7310652505/job/19919464262?pr=6467
Link to successful CI run in our 2.13.x branch: https://github.com/timescale/timescaledb/actions/runs/7314107994/job/19926391007?pr=6470
Disable-check: force-changelog-file