Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OpenSSL 3.1.4 for OS X builds #6470

Merged
merged 1 commit into from
Dec 26, 2023
Merged

Conversation

jnidzwetzki
Copy link
Contributor

@jnidzwetzki jnidzwetzki commented Dec 24, 2023

This patch changes the OpenSSL version for the OS X builds to 3.1.4,
since recent PostgreSQL versions contain a bug in the SSL handling and
crash on OS X when OpenSSL 3.2.0 is used.

See: Homebrew/homebrew-core#155651


This also fixes the build problem in our 2.13.x branch
Link to current CI failures: https://github.com/timescale/timescaledb/actions/runs/7310652505/job/19919464262?pr=6467
Link to successful CI run in our 2.13.x branch: https://github.com/timescale/timescaledb/actions/runs/7314107994/job/19926391007?pr=6470
Disable-check: force-changelog-file

Copy link

codecov bot commented Dec 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2a808ca) 87.34% compared to head (c8187e1) 87.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6470      +/-   ##
==========================================
- Coverage   87.34%   87.33%   -0.02%     
==========================================
  Files         187      187              
  Lines       41869    41823      -46     
  Branches     9320     9300      -20     
==========================================
- Hits        36571    36526      -45     
+ Misses       3625     3621       -4     
- Partials     1673     1676       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jnidzwetzki jnidzwetzki changed the base branch from 2.13.x to main December 24, 2023 11:24
@jnidzwetzki jnidzwetzki changed the title Debug SSL crash Use OpenSSL 3.1.4 for OS X builds Dec 24, 2023
@jnidzwetzki jnidzwetzki added ci force-auto-backport Automatically backport this PR or fix of this issue, even if it's not marked as "bug" labels Dec 24, 2023
@jnidzwetzki jnidzwetzki marked this pull request as ready for review December 24, 2023 11:38
Copy link

@gayyappan, @akuzm: please review this pull request.

Powered by pull-review

This patch changes the OpenSSL version for the OS X builds to 3.1.4
since recent PostgreSQL versions contain a bug in the SSL handling and
crash on OS X when OpenSSL 3.2.0 is used.

See: Homebrew/homebrew-core#155651
@jnidzwetzki jnidzwetzki merged commit e150a17 into timescale:main Dec 26, 2023
42 checks passed
@timescale-automation
Copy link

Automated backport to 2.13.x not done: cherry-pick failed.

Git status

HEAD detached at origin/2.13.x
You are currently cherry-picking commit e150a174d.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   .github/gh_matrix_builder.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   .github/workflows/linux-build-and-test.yaml


Job log

@timescale-automation timescale-automation added auto-backport-not-done Automated backport of this PR has failed non-retriably (e.g. conflicts) backported-2.13.x labels Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport-not-done Automated backport of this PR has failed non-retriably (e.g. conflicts) backported-2.13.x ci force-auto-backport Automatically backport this PR or fix of this issue, even if it's not marked as "bug"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants