Time Vector Templates #638
Conversation
thatzopoulos
force-pushed
the
th/time-vector-template-json
branch
5 times, most recently
from
79fba01 to
46aa1f6
Compare
thatzopoulos
force-pushed
the
th/time-vector-template-json
branch
5 times, most recently
from
6f524c6 to
10249e4
Compare
extension/src/time_vector.rs
Outdated
| ); | ||
|
|
||
| let test_user_supplied_template = client.select( | ||
| "SELECT toolkit_experimental.format_timevector(timevector(time, value),'{\"times\": {{ TIMES | json_encode(pretty=true) | safe }}, \"vals\": {{ VALUES | json_encode(pretty=true) | safe }}}') FROM data", |
There was a problem hiding this comment.
Is the json_encode(pretty=true) | safe required to make this look like valid JSON, can we do that by default (probably not pretty=true by default though)?
There was a problem hiding this comment.
json_encode() is required but pretty=true isn't so I can turn that off if we want to.
If you were to write this instead of using json_encode:
{\"times\": {{ TIMES }}, \"vals\": {{ VALUES }}} it would render as:
`"{\"times\": [2020-01-01 00:00:00+00, 2020-01-02 00:00:00+00, 2020-01-03 00:00:00+00, 2020-01-04 00:00:00+00, 2020-01-05 00:00:00+00], \"vals\": [30, 45, null, 55.5, 10]}"
json_encode without pretty printing:
{\"times\": {{ TIMES | json_encode() | safe }}, \"vals\": {{ VALUES | json_encode() | safe }}}'
looks like this:
"{\"times\": [\"2020-01-01 00:00:00+00\",\"2020-01-02 00:00:00+00\",\"2020-01-03 00:00:00+00\",\"2020-01-04 00:00:00+00\",\"2020-01-05 00:00:00+00\"], \"vals\": [\"30\",\"45\",\"null\",\"55.5\",\"10\"]}"`
There doesn't seem to be a good builtin way to run json_encode() on all user template code by default though. This might be something we can investigate in a future improvement?
thatzopoulos
force-pushed
the
th/time-vector-template-json
branch
from
ba4e36a to
c76ae4f
Compare
extension/src/time_vector.rs
Outdated
| context.insert("TIMES", ×); | ||
| context.insert("VALUES", &values); | ||
|
|
||
| context.insert("TIMEVALS", &timevals); // paired timevals: ex. (time,value). |
There was a problem hiding this comment.
I'm not sure either of the representations here (line 171 and 172) are that useful, we'd really like to see this output a valid JSON vector of time, value structs.
I'm guessing we can't just specify a format string like "{\"times\": {{ TIMES | json_encode(pretty=true) | safe }}, \"vals\": {{ VALUES | json_encode(pretty=true) | safe }}}" here? Could we just parse the string ourselves and replace occurrences of TIMEVAL with that string?
There was a problem hiding this comment.
That makes sense, I am currently trying to get that first idea to work and if it does not I will try out the second approach.
I got the first approach working once I turned off Tera's autoescape. This should work now:
SELECT toolkit_experimental.to_text(timevector(time, value),'{{TIMEVALS}}') FROM data
[{\"time\": \"2020-01-01 00:00:00+00\", \"val\": 30}, {\"time\": \"2020-01-02 00:00:00+00\", \"val\": 45}, {\"time\": \"2020-01-03 00:00:00+00\", \"val\": null}, {\"time\": \"2020-01-04 00:00:00+00\", \"val\": 55.5}, {\"time\": \"2020-01-05 00:00:00+00\", \"val\": 10} ]
bf07375 to
55e8135
Compare
thatzopoulos
force-pushed
the
th/time-vector-template-json
branch
from
55e8135 to
2a36d6b
Compare
|
bors r+ |
|
Build succeeded: |
These changes allow formatted String output from a Time Vector series. The
format_timevector()fn takes args for a formatted string and a Time Vector Series. The Tera crate is used to populate the formatted string with Time Vector values and render it for the user.format_timevector()has two built in templates that can be used:pairedandplotly.