Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build script option to install in release mode #592

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

syvb
Copy link
Member

@syvb syvb commented Oct 24, 2022

Being able to install Toolkit with optimizations enabled is useful for benchmarking purposes. This PR adds an option to build in release mode to the build script.

@syvb syvb requested a review from epgts October 24, 2022 14:36
Copy link
Contributor

@epgts epgts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add $mode to all the other cargo command too? At least those that support it.

Also, what do you think about using -profile [whatever] instead? --release is but a strictly less flexible synonym for --profile release.

Thanks!

@syvb
Copy link
Member Author

syvb commented Oct 24, 2022

Can you add $mode to all the other cargo command too? At least those that support it.

The only other commands are for running tests – turning on optimizations for tests is usually a bad idea (since in release mode some overflow checks are disabled and debug asserts are also removed). It should probably give an error or at least a warning if one tries to run the tests in release mode.

@syvb syvb force-pushed the sv/tools-build-release branch from 40a6dbf to 20a44b0 Compare October 24, 2022 19:33
@syvb syvb force-pushed the sv/tools-build-release branch from 20a44b0 to 99e56f8 Compare October 24, 2022 19:34
@syvb syvb requested a review from epgts October 24, 2022 19:34
@syvb
Copy link
Member Author

syvb commented Oct 24, 2022

The update test CI failed because the Docker image hasn't been updated with the latest cargo-pgx (which adds --profile to cargo pgx install). I'll push a new Docker image with the changes from #589.

@syvb
Copy link
Member Author

syvb commented Oct 24, 2022

Yep, CI passes now after pushing the updated Docker image.

@thatzopoulos thatzopoulos self-requested a review October 24, 2022 20:09
@syvb
Copy link
Member Author

syvb commented Oct 25, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 25, 2022

@bors bors bot merged commit 7765f8a into main Oct 25, 2022
@bors bors bot deleted the sv/tools-build-release branch October 25, 2022 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants