Backport/issue 6299 fix native mac os build (#6300) (#6468) #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Merge pull request #51710 from velavokr/velavokr-warn-cpu-utilization A cmake warning on job limits underutilizing CPU * Merge pull request #52196 from rschu1ze/simplify-job-limiting CMake: Simplify job limiting * Merge pull request #56971 from ClickHouse/own-cmake-for-grpc Own CMake for GRPC * Merge pull request #70671 from ClickHouse/fix-native-macos Fix native macOS build --------- Co-authored-by: Alexey Milovidov <milovidov@clickhouse.com> Co-authored-by: Robert Schulze <robert@clickhouse.com> Co-authored-by: Konstantin Bogdanov <thevar1able@users.noreply.github.com>
|
@qijun-niu-timeplus missing one change: Build_Native_Darwin_arm64:
needs: Build_Linux_X86_64
runs-on: [self-hosted, macOS, ARM64]
env:
build_directory: ${{ github.workspace }}/build
-- build_type: Release
++ build_type: RelWithDebInforeason: the RelWithDebInfo will add |
resolved, thanks |
yl-lisen
approved these changes
Dec 17, 2024
Closed
|
(Jove Github Bot) added it to the current sprint. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A cmake warning on job limits underutilizing CPU
CMake: Simplify job limiting
Own CMake for GRPC
Fix native macOS build
PR checklist:
proton: starts/endsfor new code in existing community code base ?Please write user-readable short description of the changes: