Repeat emit for global aggregation #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yl-lisen
reviewed
Oct 31, 2024
yl-lisen
reviewed
Oct 31, 2024
| @@ -51,6 +59,8 @@ struct AggregatingTransformParams | |||
| return res; | |||
| } | |||
|
|
|||
| bool repeatEmit() const noexcept { return emit_repeat && !emit_changelog && emit_mode < EmitMode::OnUpdate; } | |||
There was a problem hiding this comment.
I think we don't need it.
Since the global aggregation already checked !emit_changelog and the AST parsing ensured emit_mode must be emit periodic as well
There was a problem hiding this comment.
Why global aggr cannot emit changelog ?
yl-lisen
reviewed
Oct 31, 2024
Comment on lines
-132
to
148
| { | ||
| *rows_since_last_finalizations[current_variant] += rows; | ||
| } | ||
| void addRowCount(size_t rows, size_t current_variant) { *rows_since_last_finalizations[current_variant] += rows; } | ||
| }; |
There was a problem hiding this comment.
It is clang-formatted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist:
proton: starts/endsfor new code in existing community code base ?Please write user-readable short description of the changes:
Closed #847