-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: support kafka schema registry for Protobuf and Avro. #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenziliang
reviewed
Feb 26, 2024
chenziliang
reviewed
Feb 26, 2024
chenziliang
reviewed
Feb 26, 2024
chenziliang
reviewed
Feb 26, 2024
chenziliang
reviewed
Feb 26, 2024
chenziliang
reviewed
Feb 26, 2024
chenziliang
reviewed
Feb 26, 2024
chenziliang
reviewed
Feb 26, 2024
chenziliang
reviewed
Feb 26, 2024
chenziliang
reviewed
Feb 26, 2024
chenziliang
reviewed
Feb 26, 2024
chenziliang
reviewed
Feb 26, 2024
chenziliang
reviewed
Feb 26, 2024
chenziliang
reviewed
Feb 26, 2024
chenziliang
reviewed
Feb 26, 2024
chenziliang
reviewed
Feb 26, 2024
chenziliang
reviewed
Feb 26, 2024
chenziliang
reviewed
Feb 26, 2024
chenziliang
reviewed
Feb 26, 2024
chenziliang
reviewed
Feb 26, 2024
chenziliang
reviewed
Feb 26, 2024
chenziliang
reviewed
Feb 26, 2024
chenziliang
reviewed
Feb 26, 2024
chenziliang
reviewed
Feb 26, 2024
chenziliang
reviewed
Feb 26, 2024
chenziliang
reviewed
Feb 26, 2024
chenziliang
reviewed
Feb 26, 2024
chenziliang
reviewed
Feb 26, 2024
chenziliang
reviewed
Feb 26, 2024
chenziliang
reviewed
Feb 26, 2024
chenziliang
reviewed
Feb 26, 2024
chenziliang
reviewed
Feb 26, 2024
chenziliang
reviewed
Feb 26, 2024
In general, it looks good and let's clean up the old code which is commented out |
zliang-min
force-pushed
the
feature/protobuf-schema-registry
branch
from
February 26, 2024 21:19
90a0ae7
to
aa4c34f
Compare
chenziliang
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist:
proton: starts/ends
for new code in existing community code base ?Please write user-readable short description of the changes:
New settings added for using kafka schema registry:
kafka_schema_registry_url
andkafka_schema_registry_credentials
. Example:kafka_schema_registry_credentials
is optional, it contains the the API key and secret and a:
in between. Also, kafka schema registry can be used withdata_format = 'Avro'
.Note: in this PR, schema reference is not supported yet.