Fix clang17 build warning on SUSE Linux platform

[Shylock-Hg]

PR checklist:

• Did you run ClangFormat ?
• Did you separate headers to a different section in existing community code base ?
• Did you surround proton: starts/ends for new code in existing community code base ?

Please write user-readable short description of the changes:
Fix some compile warning in clang17.
Close #540

[CLAassistant]

All committers have signed the CLA.

[jovezhong]

Thanks @Shylock-Hg for contributing the improvement for building process on SUSE Linux. I updated the title to make it clear. Since it's in Lunar New Year holiday, the code review could be a bit slower than usual.

[chenziliang]

Thanks so much for the PR : may you help do a diff with ClickHouse community code ? We like Proton's code base to be aligned with the ClickHouse OSS as much as we can. For example, in https://github.com/ClickHouse/ClickHouse/blob/master/src/Columns/ColumnDecimal.cpp, it used my_compressed=std::move(compressed)

[Shylock-Hg]

Thanks so much for the PR : may you help do a diff with ClickHouse community code ? We like Proton's code base to be aligned with the ClickHouse OSS as much as we can. For example, in https://github.com/ClickHouse/ClickHouse/blob/master/src/Columns/ColumnDecimal.cpp, it used my_compressed=std::move(compressed)

Is there a script to do diff? And I plan to rename with prefix my_, is it accepted?

[chenziliang]

Thanks so much for the PR : may you help do a diff with ClickHouse community code ? We like Proton's code base to be aligned with the ClickHouse OSS as much as we can. For example, in https://github.com/ClickHouse/ClickHouse/blob/master/src/Columns/ColumnDecimal.cpp, it used my_compressed=std::move(compressed)

Is there a script to do diff? And I plan to rename with prefix my_, is it accepted?

We don't have a script yet and it is a manual process. I did this by using vimdiff and carefully pick what we need. Yes rename the variable names same as CH community does is what we like to have here.

[yokofly]

Edit v1: add more context
Edit v2: add regex

thanks for continue working on this pr.

The rest part seems only need to replace all the changed prefix, I have a simple but still complex way. git patch will generate a file to log changed code. consider use regex for the git patch file with vim/vscode such editor, and then git apply under a new branch, finally directly force push a new commit.

Remember take a look about git reflog if u wanna back to previous status/commit.

[yokofly]

this pr is really clear.
I locally build with ubuntu 20.04 and clang17 on this feature branch works well, and the smoke test and unit test passed.
I will check detailed a bit later.

[yokofly]

overall is good👍 will force merge this PR tomorrow.