Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor emit changelog for aggregated results (with broken changes) #552

Merged
merged 5 commits into from
Feb 5, 2024
Merged

refactor emit changelog for aggregated results (with broken changes) #552

merged 5 commits into from
Feb 5, 2024

Conversation

yl-lisen
Copy link
Collaborator

@yl-lisen yl-lisen commented Feb 3, 2024 •
edited
Loading

This close #548

Please write user-readable short description of the changes:

  • refactor emit changelog for aggregated results (broken checkpoint compatibility for emit changelog)

@yl-lisen yl-lisen requested a review from chenziliang February 3, 2024 16:24
@yl-lisen yl-lisen changed the title refactor emit changelog for aggregated results refactor emit changelog for aggregated results (With broken changes) Feb 3, 2024
@yl-lisen yl-lisen self-assigned this Feb 3, 2024
@yl-lisen yl-lisen changed the title refactor emit changelog for aggregated results (With broken changes) refactor emit changelog for aggregated results (with broken changes) Feb 3, 2024
chenziliang
chenziliang reviewed Feb 3, 2024
View reviewed changes
src/Processors/Transforms/Streaming/AggregatingHelper.cpp Outdated
{
if (data.empty())
return {};

BlocksList blocks = params.aggregator.convertToBlocks(data, params.final, params.params.max_threads);
BlocksList blocks;
if (type == ConvertType::Updates)
Copy link
Collaborator

@chenziliang chenziliang Feb 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use a switch which is less error-prone

@chenziliang
Copy link
Collaborator

Looks good in general. It is good we are refining code. Let's try to use switch (enum) when it makes sense.

@yl-lisen yl-lisen force-pushed the enhancement/issue-548-refactor-emit-changelog-for-aggregated-results branch from 7a3983f to c8a48ab Compare February 4, 2024 04:47
@yl-lisen yl-lisen requested a review from chenziliang February 4, 2024 04:47
@yl-lisen yl-lisen force-pushed the enhancement/issue-548-refactor-emit-changelog-for-aggregated-results branch from c8a48ab to 34639bb Compare February 4, 2024 04:55
@yl-lisen yl-lisen force-pushed the enhancement/issue-548-refactor-emit-changelog-for-aggregated-results branch from 6ca5ff9 to 22c9c77 Compare February 4, 2024 06:52
@yl-lisen yl-lisen requested a review from chenziliang February 5, 2024 02:06
@chenziliang chenziliang merged commit 779a9fe into develop Feb 5, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenziliang chenziliang Awaiting requested review from chenziliang

Assignees

@yl-lisen yl-lisen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance emit changelog for aggregated results
2 participants
@yl-lisen @chenziliang