New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more metrics log #492

Merged

yl-lisen merged 7 commits into develop from enhancement/issue-491-add-more-metrics-info

Jan 18, 2024

Collaborator

yl-lisen commented Jan 16, 2024 •

edited

Loading

This close #491

Please write user-readable short description of the changes:

Add aggregated data metrics
Add more metrics for cached blocks
Remove metrics serialization (we should avoid serialize/deserialize metrics, since they are volatile)

yl-lisen self-assigned this

yl-lisen force-pushed the enhancement/issue-491-add-more-metrics-info branch 5 times, most recently from 0a99755 to 819df49 Compare

January 17, 2024 18:12

yl-lisen marked this pull request as ready for review

January 17, 2024 18:29

yl-lisen requested review from chenziliang, qijun-niu-timeplus, sunset3000 and yokofly

January 18, 2024 01:37

yl-lisen force-pushed the enhancement/issue-491-add-more-metrics-info branch 2 times, most recently from f3930fa to 8ef79b7 Compare

January 18, 2024 02:10

chenziliang reviewed

View reviewed changes

src/Core/Block.cpp Show resolved Hide resolved

chenziliang reviewed

View reviewed changes

src/Interpreters/Streaming/Aggregator.cpp Outdated Show resolved Hide resolved

chenziliang reviewed

View reviewed changes

src/Interpreters/Streaming/CachedBlockMetrics.cpp Show resolved Hide resolved

chenziliang reviewed

View reviewed changes

src/Processors/Transforms/Streaming/ChangelogConvertTransform.cpp Outdated Show resolved Hide resolved

chenziliang reviewed

View reviewed changes

src/Interpreters/Streaming/CachedBlockMetrics.h Outdated Show resolved Hide resolved

yl-lisen added 3 commits

January 18, 2024 11:16


          add more metrics log

f9f4912


          remove CachedBlockMetrics serialization

573074a

fix

887e818

yl-lisen force-pushed the enhancement/issue-491-add-more-metrics-info branch from 8ef79b7 to 1e5f969 Compare

January 18, 2024 03:16


          fix comments

f763277

yl-lisen force-pushed the enhancement/issue-491-add-more-metrics-info branch from 1e5f969 to f763277 Compare

January 18, 2024 08:02

yl-lisen added 2 commits

January 18, 2024 17:55


          tweak log aggregated metrics

ceddb30


          fix smoke test

637b163

yokofly reviewed

View reviewed changes

tests/stream/test_stream_smoke/0013_changelog_stream13.yaml Outdated Show resolved Hide resolved


          fix minor

8d2e17f

qijun-niu-timeplus approved these changes

View reviewed changes

yl-lisen merged commit 1bc83df into develop

21 checks passed

yl-lisen deleted the enhancement/issue-491-add-more-metrics-info branch

January 18, 2024 13:39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet