Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Kafka external stream virtual columns #455

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

zliang-min
Copy link
Collaborator

PR checklist:

  • Did you run ClangFormat ?
  • Did you separate headers to a different section in existing community code base ?
  • Did you surround proton: starts/ends for new code in existing community code base ?

Please write user-readable short description of the changes:

closes #55
refs #175

Fixed virtual columns in Kafka external streams:

  • _tp_time now always has a value
  • _tp_append_time is set only when message timestamp is an append time
  • all time columns has DateTime64 type
  • if a virtual column is explicitly defined an a pyshcial column, it should be respected

@zliang-min zliang-min added bug Something isn't working external stream labels Dec 29, 2023
@zliang-min zliang-min self-assigned this Dec 29, 2023
@zliang-min zliang-min force-pushed the fix/es-virtual-columns branch from a24c67a to 25d2c3a Compare January 1, 2024 20:05
@chenziliang chenziliang merged commit 8b78038 into develop Jan 2, 2024
21 checks passed
@jovezhong
Copy link
Contributor

(Jove Github Bot) added it to the current sprint.

@jovezhong
Copy link
Contributor

(Jove Github Bot) moved this ticket out of the GitHub project(up to 1200 tickets for one project).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use _tp_time in tumble window for external stream
3 participants