Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable base64 function #452

Merged
merged 1 commit into from
Dec 29, 2023
Merged

enable base64 function #452

merged 1 commit into from
Dec 29, 2023

Conversation

lizhou1111
Copy link
Contributor

PR checklist:

  • Did you run ClangFormat ?
  • Did you separate headers to a different section in existing community code base ?
  • Did you surround proton: starts/ends for new code in existing community code base ?

Please write user-readable short description of the changes:

@yokofly yokofly linked an issue Dec 28, 2023 that may be closed by this pull request
Base64 decode/decode function #427
Closed
@yokofly
Copy link
Collaborator

yokofly commented Dec 28, 2023

build failure
https://github.com/timeplus-io/proton/actions/runs/7343862743/job/19994994652?pr=452#step:7:12172

have you tried in your local? the CI build scipt is using below commands:

./docker/packager/packager --package-type binary --docker-image-version clang-16 --proton-build --enable-proton-local --output-dir `pwd`/build_output

@yokofly yokofly marked this pull request as draft December 28, 2023 11:13
@yokofly yokofly marked this pull request as draft December 28, 2023 11:13
@lizhou1111 lizhou1111 force-pushed the enhancement/issue-427-enable-base64-function branch from cc29bb4 to a430078 Compare December 28, 2023 11:14
@lizhou1111 lizhou1111 marked this pull request as ready for review December 29, 2023 01:31
@yokofly yokofly merged commit dc06b55 into develop Dec 29, 2023
29 checks passed
@yokofly yokofly deleted the enhancement/issue-427-enable-base64-function branch December 29, 2023 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yokofly yokofly yokofly approved these changes

@yl-lisen yl-lisen Awaiting requested review from yl-lisen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Base64 decode/decode function
2 participants
@lizhou1111 @yokofly