Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sre): add default feature flags [INFRA-20920] #288

Closed
wants to merge 1 commit into from

Conversation

KLoganCU
Copy link

@KLoganCU KLoganCU commented Aug 30, 2024

Fixes https://click-up.slack.com/archives/C03F94339PV/p1725016267895029

adds a default FF for deployment circuit breaker to cdk.json

  "context": {
    "@aws-cdk/aws-ecs:disableExplicitDeploymentControllerForCircuitBreaker": true,
  },

@KLoganCU KLoganCU requested a review from a team as a code owner August 30, 2024 18:51
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.38%. Comparing base (aba860f) to head (8cd014c).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #288   +/-   ##
=======================================
  Coverage   99.38%   99.38%           
=======================================
  Files          17       17           
  Lines        2272     2288   +16     
  Branches      138       93   -45     
=======================================
+ Hits         2258     2274   +16     
  Misses         14       14           
Files with missing lines Coverage Δ
src/cdk-context-json.ts 100.00% <100.00%> (ø)
src/clickup-cdk.ts 97.04% <100.00%> (+0.02%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aba860f...8cd014c. Read the comment docs.

Copy link

This pull request is now marked as stale because it hasn't seen activity for a while. Add a comment or it will be closed soon. If you wish to exclude this issue from being marked as stale, add the "backlog" label.

@github-actions github-actions bot added the stale label Sep 14, 2024
Copy link

Closing this pull request as it hasn't seen activity for a while. Please add a comment @mentioning a maintainer to reopen. If you wish to exclude this issue from being marked as stale, add the "backlog" label.

@github-actions github-actions bot closed this Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant