Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(alerts): upgrade download-artifact action to v4 [CLK-483275] #254

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

mattlewis92
Copy link
Contributor

Fixes failing workflows due to the artifact being uploaded with v4 and the download action still uses v3 (which uses different APIs and fails as a result)

CleanShot 2024-03-28 at 08 45 34

@mattlewis92 mattlewis92 requested a review from a team as a code owner March 28, 2024 08:46
@mattlewis92 mattlewis92 enabled auto-merge (squash) March 28, 2024 08:46
@mattlewis92 mattlewis92 changed the title fix: upgrade download-artifact action to v4 [CLK-483275] fix(alerts): upgrade download-artifact action to v4 [CLK-483275] Mar 28, 2024
Signed-off-by: github-actions <github-actions@github.com>
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.37%. Comparing base (59e6df6) to head (d493082).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #254   +/-   ##
=======================================
  Coverage   99.37%   99.37%           
=======================================
  Files          17       17           
  Lines        2225     2225           
  Branches      140      140           
=======================================
  Hits         2211     2211           
  Misses         14       14           
Files Coverage Δ
src/datadog-service-catalog.ts 100.00% <100.00%> (ø)
src/datadog.ts 100.00% <100.00%> (ø)
src/slack-alert.ts 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59e6df6...d493082. Read the comment docs.

@mattlewis92 mattlewis92 enabled auto-merge (squash) March 28, 2024 08:48
@mattlewis92 mattlewis92 merged commit 2527d6e into main Mar 28, 2024
8 checks passed
@mattlewis92 mattlewis92 deleted the matt/CLK-483275/upgrade-download-artifact branch March 28, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants