Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(clickup-cdk): avoid v2.87.0 [CLK-274818] #197

Closed
wants to merge 1 commit into from
Closed

fix(clickup-cdk): avoid v2.87.0 [CLK-274818] #197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/clickup-cdk.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ export module clickupCdk {
// When deploying from cdkPipelines, it will use whatever version the library is currently on per yarn.lock.
let cdkVersion = undefined;
if (semver.lt(options.cdkVersion, '2.64.0')) {
cdkVersion = '2.87.0'; // Arbitrary newish version. Most developers will want the latest.
cdkVersion = '2.90.0'; // https://github.com/aws/aws-cdk/issues/26325
console.warn(
`Your cdkVersion of ${options.cdkVersion} is less than 2.64.0. We recommend using latest, which you can find at https://github.com/aws/aws-cdk/releases . Until you explicitly set something, we are pushing to ${cdkVersion}`,
);
Expand Down
8 changes: 4 additions & 4 deletions test/__snapshots__/clickup-cdk.test.ts.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.