Skip to content

Commit

Permalink
feat: allow pnpm [CLK-252116]
Browse files Browse the repository at this point in the history
  • Loading branch information
ahammond committed May 10, 2024
1 parent f6294af commit 38c6f4c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 15 deletions.
6 changes: 1 addition & 5 deletions src/clickup-cdk.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { awscdk, Component, javascript, JsonPatch, SampleDir, SampleReadme } from 'projen';
import { awscdk, Component, JsonPatch, SampleDir, SampleReadme } from 'projen';
import * as semver from 'semver';
import merge from 'ts-deepmerge';

Expand Down Expand Up @@ -204,10 +204,6 @@ export module clickupCdk {
readonly workflowNodeVersion?: string;

constructor(options: ClickUpCdkTypeScriptAppOptions) {
if (options.packageManager === javascript.NodePackageManager.PNPM) {
throw new Error('pnpm not supported by cdkPipelines: https://staging.clickup.com/t/333/CLK-252116');
}

// This cdkVersion is actually the minimum version that's compatible. This only affects devDeps.
// This really only affects users when they try to deploy directly from their laptop.
// When deploying from cdkPipelines, it will use whatever version the library is currently on per yarn.lock.
Expand Down
11 changes: 1 addition & 10 deletions test/clickup-cdk.test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import path from 'path';
import { Testing, javascript } from 'projen';
import { Testing } from 'projen';
import { requiredParams } from './requiredParams';
import { clickupCdk } from '../src';
import { datadogServiceCatalog } from '../src/datadog-service-catalog';
Expand Down Expand Up @@ -38,15 +38,6 @@ describe('ClickUpCdkTypeScriptApp', () => {
expect(p.datadogEvent).toBeFalsy();
});

test('pnpm throws', () => {
expect(() => {
new clickupCdk.ClickUpCdkTypeScriptApp({
...requiredParams,
packageManager: javascript.NodePackageManager.PNPM,
});
}).toThrowError(/pnpm not supported by cdkPipelines/);
});

describe('node20', () => {
p = new clickupCdk.ClickUpCdkTypeScriptApp({
...requiredParams,
Expand Down

0 comments on commit 38c6f4c

Please sign in to comment.