Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inbox): Only render modified stacks in the diff output comment #7

Merged
merged 4 commits into from
Feb 24, 2023

Conversation

m-szaf
Copy link
Collaborator

@m-szaf m-szaf commented Feb 23, 2023

Per https://click-up.slack.com/archives/C03F94339PV/p1677168867609029

  • Only rendering the modified stacks to clean up the uber output (See snapshot for the difference!)
  • ALSO use regex backtracking to ensure that SSM changes don't get filtered out erroneously

@m-szaf m-szaf requested a review from pkukulski February 23, 2023 16:55
@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Merging #7 (ed38519) into main (09a2068) will increase coverage by 0.83%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
+ Coverage   71.71%   72.54%   +0.83%     
==========================================
  Files           3        3              
  Lines          99      102       +3     
  Branches       15       16       +1     
==========================================
+ Hits           71       74       +3     
  Misses         26       26              
  Partials        2        2              
Impacted Files Coverage Δ
src/parsingLogic.ts 96.10% <100.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09a2068...ed38519. Read the comment docs.

@m-szaf m-szaf merged commit 8cf67eb into main Feb 24, 2023
@m-szaf m-szaf deleted the Morgan-Szafranski/only-add-changed-stacks-to-the-diff branch February 24, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants