-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): use writer and readers instead [CLK-272228] #85
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #85 +/- ##
==========================================
+ Coverage 96.55% 96.58% +0.02%
==========================================
Files 6 6
Lines 1741 1756 +15
Branches 185 187 +2
==========================================
+ Hits 1681 1696 +15
Misses 60 60
Continue to review full report in Codecov by Sentry.
|
d08a657
to
93b7495
Compare
Looks good! Final testing:
|
run the following to make sure there is no diff:
then run:
which gives:
for each stack, run:
|
i did the following:
gives the following diff:
gives the following diff:
|
82f617f
to
706fa0e
Compare
706fa0e
to
f4618d2
Compare
Signed-off-by: github-actions <github-actions@github.com>
follow the workaround here: aws/aws-cdk#27177 there is no diff from |
what
https://staging.clickup.com/t/333/CLK-272228
follow this aws migration doc: https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_rds-readme.html#migrating-from-instanceprops
test
npx progen test
and deprecation warning is gone.@ahammond please advise other test steps needed.