Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does .eslintignore not work? #106

Closed
fadehelix opened this issue Oct 1, 2017 · 1 comment · Fixed by #107
Closed

Does .eslintignore not work? #106

fadehelix opened this issue Oct 1, 2017 · 1 comment · Fixed by #107

Comments

@fadehelix
Copy link

I want to ignore src/registerServiceWorker.js file and the simplest way to achieve this is to add the path to the .eslintignore file.
But the file is always linted.

If I add /* eslint-disable */ at the top of the ignored file then it works as expected.
@timarney
Copy link
Owner

timarney commented Oct 2, 2017

Not familiar with how that works myself but likely has to do with facebook/create-react-app#2339 (comment)

@peet peet mentioned this issue Oct 4, 2017
Merged
flyskywhy added a commit to flyskywhy/PixelShapeRN that referenced this issue Feb 21, 2022
@flyskywhy
react -> react-native: fix Web [Does .eslintignore not work?](timarne…
d9d0883 
…y/react-app-rewired#106)
flyskywhy added a commit to flyskywhy/g that referenced this issue Feb 21, 2022
@flyskywhy
React使用详解.md: fix react-app-rewired Web hot reloading meat [Uncaught …
fee9926 
…ReferenceError: process is not defined](facebook/create-react-app#11771) ;

    fix react-app-rewired sometimes is not honouring the eslint rules in '.eslintrc.js', so it's ok to enable the eslint rules @ timarney/react-app-rewired#452 ;
    fix react-app-rewired [Does .eslintignore not work?](timarney/react-app-rewired#106)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

allow .eslintignore files to be used peet/react-app-rewired
2 participants
@timarney @fadehelix