Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Update @actions/core to v1.10.0 #14

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

madelinevdp
Copy link

Fixes #13 - set-output command is deprecated, and has been for quite some time. Guidance was to update @actions/core to v1.10.0 or greater.

Note: this updated the package-lock file version, which is why it looks so large.

Testing:
npm run build completes successfully, but npm run test was failing prior to the change and outputs the same errors after the change.

This should resolve deprecation warnings that are currently shown when running the GitHub action.

Fixes tim-actions#13 - set-output command is deprecated, and has been for quite
some time. Guidance was to update `@actions/core` to v1.10.0 or greater.
@madelinevdp
Copy link
Author

@Tim-Zhang I would appreciate your review and help merging this please 🙂 (It won't let me add you as a reviewer or assign the PR to you)

Copy link

@Tim-Zhang Tim-Zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@madelinevdp LGTM, thanks

@Tim-Zhang Tim-Zhang merged commit 094fc16 into tim-actions:master Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set-output command is deprecated
2 participants