Only generate a certificate if an existing in memory certificate isn't already set #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t set Signed-off-by: David Negstad <David.Negstad@microsoft.com>
danegsta
force-pushed
the
dev/danegsta/generate-cert
branch
from
ab85122
to
dfabe8a
Compare
nicks
reviewed
Mar 22, 2024
Signed-off-by: David Negstad <David.Negstad@microsoft.com>
nicks
approved these changes
Mar 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've got a use case where I'd like to be able to provide my own in memory generated certificate to tilt-apiserver. Current behavior only allows providing certificates via files, otherwise tilt-apiserver generates an in memory certificate for me. This change simply checks to see if someone has specified their own in memory certificate and skips the default generation logic if they have.