Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: add selection predicates #40

Merged
merged 1 commit into from
Jun 25, 2021
Merged

storage: add selection predicates #40

merged 1 commit into from
Jun 25, 2021

Conversation

nicks
Copy link
Member

@nicks nicks commented Jun 23, 2021

Hello @milas,

Please review the following commits I made in branch nicks/labels:

1894683 (2021-06-23 18:52:31 -0400)
storage: add selection predicates

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks nicks requested a review from milas June 23, 2021 22:52
@nicks
Copy link
Member Author

nicks commented Jun 23, 2021

ahhhh this storage plugin i forked is even more half-implemented than i expected 😮

@nicks nicks merged commit f173ded into main Jun 25, 2021
@nicks nicks deleted the nicks/labels branch June 25, 2021 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milas milas milas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicks @milas