Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: handle missing clusters correctly #259

Merged
merged 1 commit into from
Oct 17, 2022
Merged

cluster: handle missing clusters correctly #259

merged 1 commit into from
Oct 17, 2022

Conversation

nicks
Copy link
Member

@nicks nicks commented Oct 17, 2022

Hello @nicksieger, @milas,

Please review the following commits I made in branch nicks/cluster:

7cb7ff2 (2022-10-17 11:57:38 -0400)
cluster: handle missing clusters correctly
Signed-off-by: Nick Santos nick.santos@docker.com

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks nicks requested review from milas and nicksieger October 17, 2022 15:58
Signed-off-by: Nick Santos <nick.santos@docker.com>
@nicks nicks merged commit b9b3bc9 into main Oct 17, 2022
@nicks nicks deleted the nicks/cluster branch October 17, 2022 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants