Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: handle containerd on minikube 1.27 #255

Merged
merged 1 commit into from
Sep 16, 2022
Merged

cluster: handle containerd on minikube 1.27 #255

merged 1 commit into from
Sep 16, 2022

Conversation

nicks
Copy link
Member

@nicks nicks commented Sep 16, 2022

Hello @nicksieger,

Please review the following commits I made in branch nicks/issue239:

41bf3d9 (2022-09-16 12:16:28 -0400)
cluster: handle containerd on minikube 1.27
#239

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

Fixes #239
Signed-off-by: Nick Santos <nick.santos@docker.com>
Copy link
Member

@nicksieger nicksieger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least the v2 registry config is easier to manage than the worst embedded sed command ever. LGTM

@nicks nicks merged commit 8b6cb38 into main Sep 16, 2022
@nicks nicks deleted the nicks/issue239 branch September 16, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants